Skip to content

RHOAIENG-62238: fix sdk tests (byoidc and non-byoidc)#1087

Merged
pawelpaszki merged 3 commits into
project-codeflare:mainfrom
pawelpaszki:RHOAIENG-62238-main
May 13, 2026
Merged

RHOAIENG-62238: fix sdk tests (byoidc and non-byoidc)#1087
pawelpaszki merged 3 commits into
project-codeflare:mainfrom
pawelpaszki:RHOAIENG-62238-main

Conversation

@pawelpaszki

@pawelpaszki pawelpaszki commented May 13, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Contributor

Issue link

What changes have been made

RHOAIENG-62238: fix sdk tests (byoidc and non-byoidc)

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci-robot

openshift-ci-robot commented May 13, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Collaborator

@pawelpaszki: This pull request references RHOAIENG-62238 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Issue link

What changes have been made

RHOAIENG-62238: fix sdk tests (byoidc and non-byoidc)

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@codecov

codecov Bot commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.61%. Comparing base (1b46de2) to head (3803d0a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1087   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          23       23           
  Lines        2306     2306           
=======================================
  Hits         2228     2228           
  Misses         78       78

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kryanbeane
kryanbeane reviewed May 13, 2026
View reviewed changes
Comment thread tests/upgrade/01_raycluster_sdk_upgrade_test.py Outdated
@pawelpaszki

pawelpaszki commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2026
@openshift-ci

openshift-ci Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026
@pawelpaszki pawelpaszki merged commit cf2b4c0 into project-codeflare:main May 13, 2026
29 of 32 checks passed
@pawelpaszki pawelpaszki deleted the RHOAIENG-62238-main branch May 13, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kryanbeane kryanbeane kryanbeane approved these changes

@CathalOConnorRH CathalOConnorRH Awaiting requested review from CathalOConnorRH

@chipspeak chipspeak Awaiting requested review from chipspeak

Assignees

@kryanbeane kryanbeane

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pawelpaszki @openshift-ci-robot @kryanbeane